[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnash-dev] Re: Nellymoser audio segfaults (bug #24355])

From: Benjamin Wolsey
Subject: [Gnash-dev] Re: Nellymoser audio segfaults (bug #24355])
Date: Tue, 23 Sep 2008 15:22:16 +0200

>         /// Create a VideoDecoder for the specified codec_type
>         //
>         /// @return 0 if no decoder could be created for the specified 
> encoding
>         ///
>         virtual std::auto_ptr<VideoDecoder> createVideoDecoder(VideoInfo& 
> info)=0;
> I like that design in general.
> Yes, there might be other exceptions thrown for OOM conditions or similar,
> but I'd rather have MediaHandler catch them then MediaHandler users.

Also, I think it's a good design to get something back from a failed
createVideoDecoder that tells you what went wrong. After all, it fails
because of something passed in by the caller. If you get 0, you have no
idea what happened. A descriptive MediaException throw fulfils that.


Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil

reply via email to

[Prev in Thread] Current Thread [Next in Thread]