[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-dev] Alignment in AMF data

From: Rob Savoye
Subject: Re: [Gnash-dev] Alignment in AMF data
Date: Fri, 24 Oct 2008 13:31:50 -0600
User-agent: Thunderbird (X11/20080723)

strk wrote:

> readNetworkShort and readNetworkLong use bitshifting, so single copy and
> byte order agnostic:

> Maybe we really want a readNetworkDouble ...

  We don't need to keep adding duplicate functions for code we already
have that is heavily tested! How you swap the bytes is less important as
long as it's byte order agnostic, like the current functions or macros.
For example, all the code in libamf uses the standard macros or
swapBytes() and works on both big endian and little endian, plus 64 bit
systems of both. There is rarely ever a good reason to duplicate
existing code with minor differences.

        - rob -

reply via email to

[Prev in Thread] Current Thread [Next in Thread]