Re: [Gnash-dev] File renaming

[Benjamin Wolsey]

> It seems fine to use the package system to organize the simple Objects,
> but why also move DisplayObjects there, when it separates the central
> and related API classes like MovieClip and TextField from each other? I
> mentioned that I personally would like these classes to stay in the
> libcore directory where they are easy to find, and would like at least
> some discussion before they are moved.
> 

Since the testsuite failed again this morning, I've reverted three
separate changes that all caused failures. These were the changes to
TextFormat, ContextMenu and TextField. The first two should be easy to
recommit after fixing them (hint: testsuite/actionscript.all), for
TextField I would like at least the TextField class to stay in libcore,
even if the AS implementation is in the flash subdirectory. Any
discussion of that is of course welcome.

I don't see why anyone makes commits to trunk - which is supposed to be
stable - without running the entire testsuite first. Even the smallest
regression can break SWFs that worked before. The only cases that may
fail are the misc-haxe.all tests, which have different results according
to the haxe compiler you use, and some crashes in swfdec caused by a bug
that's been around for a while but was hidden until a change to
network.cpp.

bwy

--
Yes, YouTube does work in Gnash
http://www.gnu.org/software/gnash/

Benjamin Wolsey, Software Developer - http://benjaminwolsey.de

signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil