[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-dev] Re: "refreshing video frame for the first time"

From: strk
Subject: Re: [Gnash-dev] Re: "refreshing video frame for the first time"
Date: Sun, 14 Jun 2009 17:44:23 +0200

On Sun, Jun 14, 2009 at 05:23:30PM +0200, strk wrote:
> On Sun, Jun 14, 2009 at 05:19:23PM +0200, Benjamin Wolsey wrote:
> > > I now see that the way NetStream checks for that video frame
> > > existance isn't correct anymore.  It probably was when I first
> > > wrote that code but was changed later. Basically m_imageframe
> > > member of NetStream was not-null after first frame was decoded,
> > > while it is now an auto_ptr thus made null whenever the Video
> > > DisplayObject fetches a frame. Do you remember any change made
> > > about that yourself Ben ?
> > > 
> > 
> > I vaguely remember some changes some months ago, but not exactly what.
> > Are there any tests in the testsuite for this (obviously no automatic
> > ones if it is a regression)? It sounds like it would be difficult to
> > test without a long buffering time, and that would be unpredictable for
> > an automatic test.
> No, no automatic tests. The "regression" wouldn't have any
> user-noticeable effects as the refreshVideoFrame would just
> do nothing (buffer time is checked by the called function too).
> Is just an annoyance for the misleading debugging message.

Actually, dont' trust me blind on this.
A cleanup pass to NetStream_as.cpp might prove me wrong..


 Free GIS & Flash consultant/developer      ()  ASCII Ribbon Campaign  /\  Keep it simple! 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]