[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnash-dev] [PATCH] utilities/findwebcam.cpp: fix exercise in futility -

From: Richard Wilbur
Subject: [Gnash-dev] [PATCH] utilities/findwebcam.cpp: fix exercise in futility -> initialize deviceNumber
Date: Mon, 27 Jul 2009 14:58:17 -0600

Greetings Ladies and Gentlemen:

I happened to notice a line in data::data() that instead of initializing
the member deviceNumber, amounts to an exercise in futility.  By
declaring the type, 'gint deviceNumber = -1;' declares a local variable
in the data constructor which hides the member and is initialized to -1,
leaving the member to be initialized with int() which returns 0.

This one-line patch corrects the inferred intention of that code.  I
cannot currently test as the code presently segfaults.  The baseline
segfaulted for me before this patch, though.  That situation will be
covered in my next message.


Richard Wilbur
OpenPGP Public Key: 

Attachment: fix_data_ctor.patch
Description: Text Data

Attachment: signature.asc
Description: This is a digitally signed message part

reply via email to

[Prev in Thread] Current Thread [Next in Thread]