[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnash-dev] [PATCH] utilities/findwebcam.cpp: fix exercise in futili
Benjamin T Limmer
Re: [Gnash-dev] [PATCH] utilities/findwebcam.cpp: fix exercise in futility -> initialize deviceNumber
Mon, 27 Jul 2009 15:03:02 -0600
Thanks for noticing this error. This patch is merged up to trunk (revno.
On Mon, 2009-07-27 at 14:58 -0600, Richard Wilbur wrote:
> Greetings Ladies and Gentlemen:
> I happened to notice a line in data::data() that instead of initializing
> the member deviceNumber, amounts to an exercise in futility. By
> declaring the type, 'gint deviceNumber = -1;' declares a local variable
> in the data constructor which hides the member and is initialized to -1,
> leaving the member to be initialized with int() which returns 0.
> This one-line patch corrects the inferred intention of that code. I
> cannot currently test as the code presently segfaults. The baseline
> segfaulted for me before this patch, though. That situation will be
> covered in my next message.
> Richard Wilbur
> OpenPGP Public Key:
> Gnash-dev mailing list