[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-dev] Gnash ExternalInterface check leaking memory?

From: Rob Savoye
Subject: Re: [Gnash-dev] Gnash ExternalInterface check leaking memory?
Date: Fri, 06 Aug 2010 18:59:29 -0600
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20100720 Fedora/3.1.1-1.fc13 Lightning/1.0b2 Thunderbird/3.1.1

On 08/05/10 20:58, John Gilmore wrote:
> When I went to patch the select() in
> ExternalInterface::ExternalEventCheck, I noticed that it allocates a
> buffer with "char *buf = new char[bytes+1];", then fills buf from a
> read(), then passes it to parseInvoke, But nobody ever deletes buf.

  Ok, with revno #12365, I disabled the select(), and used a
boost::scoped_array instead, which will go away when the
ExternalEventCheck() returns.

> This is the only call to parseInvoke, so perhaps its argument type
> should be changed.

  It gets converted to a string anyway, as parseInvoke() uses std::
string methods like string::find().

        - rob -

reply via email to

[Prev in Thread] Current Thread [Next in Thread]