[Gnash-dev] Gst media parser warning may be hiding bug

[John Gilmore]

GCC complained (many times) while building, but this warning on this
function seemed like an issue to me:

gst/MediaParserGst.cpp:257: warning: comparison of unsigned expression >= 0 is 
always true

/// The idea here is that probingConditionsMet will return false, unless:
/// a) all data types in the stream were found.
/// b) The timer (currently for 1 second) has expired, if and only if we
///    succeeded in pushing MIN_PROBE_SIZE bytes into the bin. This should
///    protect low-bandwidth cases from stopping the probe early.

bool MediaParserGst::probingConditionsMet(const SimpleTimer& timer)
{
    return foundAllStreams() || (timer.expired() && getBytesLoaded() >= 
MIN_PROBE_SIZE);
}

MIN_PROBE_SIZE is set to zero near a commented out section:

#define PUSHBUF_SIZE 1024
//#define MIN_PROBE_SIZE (PUSHBUF_SIZE * 3)
#define MIN_PROBE_SIZE 0

This function appears to be the only place that MIN_PROBE_SIZE is used.
So, the function devolves to:

    return foundAllStreams() || timer.expired();

Is that what the code should be doing?

        John