[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnash-dev] [patch] Improve gst handling of microphone gain - fix te
Re: [Gnash-dev] [patch] Improve gst handling of microphone gain - fix testsuite failure
Mon, 22 Nov 2010 11:12:41 +0100
On Mon, Nov 22, 2010 at 10:57:43AM +0100, Petter Reinholdtsen wrote:
> I had a look at this testsuite failure:
> FAIL: Microphone_asv7.swf: setGain(77) failed, got 76 Microphone_as.hx: 244
> FAIL: Microphone_asv8.swf: setGain(77) failed, got 76 Microphone_as.hx: 244
> FAIL: Microphone_asv6.swf: setGain(77) failed, got 76 Microphone_as.hx: 244
> The cause is in the gst implementation of setGain()/gain(), which
> transform the input value of 0-100 to -60-60, and get a rounding error
> that converts 77 to 76.
> To avoid this, I propose to change the AudioInputGst class
> implementation to store the original value set using setGain() in its
> state, and convert it to the gst range when it is passed to gstreamer.
> This patch implement that change.
Good for me if it passes sane (tested) tests.
() Free GIS & Flash consultant/developer