[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-dev] Re: [patch] Get rid of warnings in findwebcams.cpp

From: strk
Subject: Re: [Gnash-dev] Re: [patch] Get rid of warnings in findwebcams.cpp
Date: Thu, 9 Dec 2010 18:25:07 +0100

On Thu, Dec 09, 2010 at 10:01:05AM +0100, Petter Reinholdtsen wrote:

> -            for (g=1; g < (vidVect.size()-1); g++) {
> +            for (size_t g=1; g < (vidVect.size()-1); g++) {

Brainflippin piece of code isn't it ?
It skips first and last element from the scan. Why ?

It _seems_ the loop is there to find duplicates of the just-added
device, which would explain why skippin the last (the last is 
what it's comparin to) but doesn't explain skippin the first.

Just trying to give hints to whoever is willing to clean that code
up. The warnings removal patch is correctly not changing semantic.


  ()   Free GIS & Flash consultant/developer

reply via email to

[Prev in Thread] Current Thread [Next in Thread]