gnash-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-dev] Cause of problem with test suite on OpenBSD


From: strk
Subject: Re: [Gnash-dev] Cause of problem with test suite on OpenBSD
Date: Wed, 22 Dec 2010 14:15:12 +0100

On Wed, Dec 22, 2010 at 12:40:27PM +0100, Petter Reinholdtsen wrote:

> After looking around, I suspect the only sane way to handle this is to
> require and enforce the use of GNU make, and the second best option is
> to rewrite the use of $(shell cmd).  Something like this might work:
> 
> diff --git a/testsuite/samples/Makefile.am b/testsuite/samples/Makefile.am
> index 0b0caf7..3ec335a 100644
> --- a/testsuite/samples/Makefile.am
> +++ b/testsuite/samples/Makefile.am
> @@ -18,7 +18,7 @@
> 
>  AUTOMAKE_OPTIONS = dejagnu -Wno-portability
> 
> -abs_srcdir=$(shell cd $(srcdir); pwd)
> +abs_srcdir = $(abs_top_srcdir)/testsuite/samples

Wondering where did $(abs_top_srcdir) come from I found
also $(abs_srcdir) directly defined in Makefile.
Seems to come from ./configure, not sure which macro.

So, I've committed a complete drop of it, and since I was
there removed -Wno-portability from AUTOMAKE_OPTIONS, which
was added to avoid the warning coming out for the use of $(shell).

--strk; 

  ()   Free GIS & Flash consultant/developer
  /\   http://strk.keybit.net/services.html



reply via email to

[Prev in Thread] Current Thread [Next in Thread]