[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-dev] OpenVG support coming

From: Sandro Santilli
Subject: Re: [Gnash-dev] OpenVG support coming
Date: Tue, 22 Mar 2011 22:16:59 +0100

On Tue, Mar 22, 2011 at 12:12:26PM -0600, Rob Savoye wrote:
> On 03/22/11 11:51, Benjamin Wolsey wrote:

> > If the old
> > functions are to be replaced, code in the existing three renderers needs
> > to be adapted to the new accessor and the old accessors removed.
>   I didn't adapt the existing renders to limit the initial changes to
> make it easier to review.

Does this mean you think the old functions are to be replaced ?
Is it really necessary ? Can you give more details on the issue ?

> I could care less whether you review this
> code in detail or not, that's up to you.

I don't think such approach to peer reviewing helps code quality.

> All I'm doing is giving you and
> others the option to review it while I'm still making minor changes.

I hope you'll be as wise to also accept the reviews and act upon them.
Happy hacking.


  ()   Free GIS & Flash consultant/developer

reply via email to

[Prev in Thread] Current Thread [Next in Thread]