[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-dev] OpenVG support coming

From: Sandro Santilli
Subject: Re: [Gnash-dev] OpenVG support coming
Date: Tue, 22 Mar 2011 22:38:17 +0100

On Tue, Mar 22, 2011 at 03:24:42PM -0600, Rob Savoye wrote:
> On 03/22/11 15:16, Sandro Santilli wrote:
> > Does this mean you think the old functions are to be replaced ?
> > Is it really necessary ? Can you give more details on the issue ?
>   It's not necessary, but as bwy pointed out, there currently there is
> some duplication of accessors that work slightly differently. I had
> planned to make all the existing renderers work "the new way", but like
> I said, that's the following phase after this one. I have enough to do
> before this gets merged in as it is.

Wouldn't it be easier and safer just to change the _new_ code to use the
_existing_ accessors ? It probably helps reducing bugs if changes in
interfaces are avoided as much as possible.

> I don't need a code review to check this in, I'm just trying to give
> anyone that cares a chance for input before I do so.

Surely you don't need a review to check it in, but don't you want it ?
Feedback of any kind (bug reports included) should be highly welcome
when you're striving for quality. 
Personally, I'd add an item about this in the CommitRules wikipage.

In this specific case, if compiler is giving you the first review,
please take it, or it'll be harder for others to get their own code
review (it's hard to read compiler warnings when you have a lot).


  ()   Free GIS & Flash consultant/developer

reply via email to

[Prev in Thread] Current Thread [Next in Thread]