gnash-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnash-dev] GetCurrentThreadId()


From: zhonghua zhu
Subject: [Gnash-dev] GetCurrentThreadId()
Date: Sat, 28 May 2011 10:50:56 +0800

Hi, guys.
There is such a call In libbase/log.cpp:

#ifdef HAVE_PTHREADS
# ifdef __APPLE_CC__
    return reinterpret_cast<unsigned long int>(pthread_self());
# else
    // This isn't a proper style C++ cast, but FreeBSD has a problem with
    // static_cast for this as pthread_self() returns a pointer. We can
    // use that too, this ID is only used for the log file to keep output
    // from seperare threads clear.
# ifdef _WIN32
    return GetCurrentThreadId();
#else
    return (unsigned long int)pthread_self();
#endif
# endif
#else
# ifdef _WIN32
    return GetCurrentThreadId();
# else
    return static_cast<unsigned long int>(getpid());
# endif
#endif

But I couldn't find #include "windows.h", things.
There is a comment in librender/XXX
#include "gnashconfig.h"

// WIN32 includes.  We don't want to have to include windows.h because
// it's such a pig, so #define a couple things that are required to
// make the gl.h stuff work.
#if defined(_WIN32) || defined(WIN32)

// GL extension constants...
#       ifdef HAVE_SDL_H
#               include <SDL_opengl.h>
#       else
#               define GL_VERTEX_ARRAY_RANGE_NV          0x851D

So my questions is, do we have the plan to support WIN32? I mean
purely WIN32, like GetCurrentThreadId things? If we did have, add
windows.h to include path. As the comment says, we don't want to. So
if we don't want to , just replace GetCurrentThreadId with something
else.

This is my opinion. What you say?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]