[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
gnats/118: Editing users email address is not always recorded in audit-t
From: |
opel |
Subject: |
gnats/118: Editing users email address is not always recorded in audit-trail |
Date: |
25 Oct 2000 01:37:12 -0000 |
>Number: 118
>Category: gnats
>Synopsis: Editing users email address is not always recorded in
>audit-trail
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: unassigned
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Tue Oct 24 18:44:00 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator: Steffen Opel
>Release: gnats-4.0-alpha
>Organization:
>Environment:
Linux gg.geekgadgets.org 2.2.16-22 #1 Tue Aug 22 16:49:06 EDT 2000 i686 unknown
>Description:
The editing users email address is not always recorded in the audit-trail
because it is not initialized to a default value when submitting the
database/user/password triple. The relevant code has been removed in CVS
revision 1.46 without proper replacement, see fix below.
>How-To-Repeat:
File a PR, access the database via gnatsd and submit a change that results in
an audit-trail entry and notice the missing email address in
"State-Changed-By:".
>Fix:
Index: gnats/ChangeLog
===================================================================
RCS file: /cvs/gnats/gnats/gnats/ChangeLog,v
retrieving revision 1.159
diff -c -r1.159 ChangeLog
*** ChangeLog 2000/08/23 19:55:22 1.159
--- ChangeLog 2000/10/25 01:16:14
***************
*** 1,3 ****
--- 1,7 ----
+ 2000-10-25 Steffen Opel <address@hidden>
+
+ * cmds.c (gnatsChdb): Default editing users email address.
+
Wed Aug 23 12:49:59 2000 Bob Manson <address@hidden>
* pr.c (verifyMultiEnum): Accept NULL values if the field doesn't
Index: gnats/cmds.c
===================================================================
RCS file: /cvs/gnats/gnats/gnats/cmds.c,v
retrieving revision 1.49
diff -c -r1.49 cmds.c
*** cmds.c 2000/08/15 00:12:39 1.49
--- cmds.c 2000/10/25 01:16:15
***************
*** 647,652 ****
--- 654,662 ----
freeDatabaseInfo (currentDatabase);
}
currentDatabase = new_db;
+
+ /* Default an editing users email address */
+ editEmailAddr = get_responsible_addr (currentDatabase, 0, 0,
username);
if (! quiet)
{
>Release-Note:
>Audit-Trail:
>Unformatted:
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- gnats/118: Editing users email address is not always recorded in audit-trail,
opel <=