gnats/484: "send-pr --request-id" sends just a template instead of request

[skoot]

>Number:         484
>Notify-List:    
>Category:       gnats
>Synopsis:       "send-pr --request-id" sends just a template instead of request
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jun 30 15:44:04 -0400 2003
>Originator:     Mariusz Pekala
>Release:        4.0 (CVS)
>Organization:

>Environment:
System: Linux cthulhu 2.4.20-18.7 #1 Thu May 29 08:57:32 EDT 2003 i686 unknown
>Description:
On a fresh install of GNATS I issued the command
  send-pr --request-id
and it told me that
  send-pr: problem report filed
That's OK.
Now I found in /usr/local/com/gnatsdb/pending new file.  That's OK.
The contents of the file is just the template ready to be edited. For example 
subject is:

Subject: <One-line summary of the PR (one line)>

The send-pr prepares the message with correctly set subject (and with other 
fields) as a TEMP file. However it send the initial template that it started 
with. For other options (other than --request-id) there is a line in the code 
that copies the TEMP back into the initial template file.
>How-To-Repeat:
1) send-pr --request-id
2) see the pending PRs.
>Fix:
The proposed patch corrects this behaviour, compiles fine, works fine. I am not 
sure whether the comments need to be cleaned (sorry - limited time :-) however 
it's safe. Maybe just a 'cp' will suffice?

address@hidden send-pr]$ cvs diff send-pr.sh
Index: send-pr.sh
===================================================================
RCS file: /cvsroot/gnats/gnats/send-pr/send-pr.sh,v
retrieving revision 1.23
diff -u -3 -p -r1.23 send-pr.sh
--- send-pr.sh  29 Oct 2002 09:58:15 -0000      1.23
+++ send-pr.sh  30 Jun 2003 19:19:27 -0000
@@ -449,6 +449,12 @@ fi

 # TEMP is the PR that we are editing.  When we're done, REF will contain
 # the final PR to be sent.
+if [ -n "$REQUEST_ID" ]
+then
+  #    Remove comments (or just copy)
+  echo '/^SEND-PR:/d' >> $FIXFIL
+  sed -f $FIXFIL $TEMP > $REF
+fi

 while [ -z "$REQUEST_ID" ]; do
   CNT=0
>Unformatted: