gnats/508: Emacs interface gnats-change-database fails when gnats-port isn't set

[bug-gnats]

>Number:         508
>Category:       gnats
>Synopsis:       Emacs interface gnats-change-database fails when gnats-port is
n't set
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Oct 24 04:25:10 -0500 2005
>Originator:     Raymond Scholz
>Release:        GNATS 4.1.0
>Organization:
>Environment:
SuSE Linux 9.2, GNU Emacs 22.0.50 (from CVS)
>Description:
When `gnats-port' is not explicitly set, gnats.el will fail when calling `gnats
- -change-database' because the default port is supplied as integer where it 
shou
ld be a string.  

Backtrace:

Debugger entered--Lisp error: (wrong-type-argument stringp 1529)
  read-from-minibuffer("Port: " 1529)
  (string-to-number (read-from-minibuffer "Port: " (if gnats-port ... 1529)))
  (list (read-from-minibuffer "Database: " gnats-database) (read-from-minibuffe
r "Host: " (or gnats-server "localhost")) (string-to-number (read-from-minibuff
er "Port: " ...)) (read-from-minibuffer "User: " (or gnats-user ...)))
  call-interactively(gnats-change-database)
>How-To-Repeat:
Put this in you .emacs:
(require 'gnats)
(setq gnats-server "your.gnats.server")
(setq gnats-port nil)
M-x gnats-change-database <RET>
default <RET>
<RET>
<RET>


>Fix:
See attached patch.
>Notify-List:    
>Unformatted:
 ----gnatsweb-attachment----
 Content-Type: text/x-patch; name="gnats-4.1.0-elisp-port.diff"
 Content-Transfer-Encoding: base64
 Content-Disposition: attachment; filename="gnats-4.1.0-elisp-port.diff"
 
 LS0tIC4vZ25hdHMvZ25hdHMuZWwJMjAwMi0wOC0wNCAxOToxNjoyOS4wMDAwMDAwMDAgKzAyMDAK
 KysrIC4uL2duYXRzLTQuMS4wLXBhdGNoZWQvZ25hdHMvZ25hdHMuZWwJMjAwNS0xMC0yNCAxMDo1
 Mjo0Ny42ODM2MDk5NzYgKzAyMDAKQEAgLTE2MjYsNyArMTYyNiw3IEBACiAJIChzdHJpbmctdG8t
 bnVtYmVyCiAJICAocmVhZC1mcm9tLW1pbmlidWZmZXIgIlBvcnQ6ICIgKGlmIGduYXRzLXBvcnQK
 IAkJCQkJICAgICAoZm9ybWF0ICIlZCIgZ25hdHMtcG9ydCkKLQkJCQkJICAgMTUyOSkpKQorCQkJ
 CQkgICAiMTUyOSIpKSkKIAkgKHJlYWQtZnJvbS1taW5pYnVmZmVyICJVc2VyOiAiIChvciBnbmF0
 cy11c2VyICh1c2VyLWxvZ2luLW5hbWUpKSkpKQogICAoc2V0cSBnbmF0cy1kYXRhYmFzZSBkYXRh
 YmFzZQogCWduYXRzLXNlcnZlciBob3N0Cg==
 


------- End of Forwarded Message