gnats/628: pr-edit Gripes About Invalid Pointer

[bug-gnats]

>Number:         628
>Category:       gnats
>Synopsis:       pr-edit Gripes About Invalid Pointer
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jul 19 17:22:00 -0500 2006
>Originator:     Keith Vetter
>Release:        4.1.0
>Organization:
Spoonbill
>Environment:
Linux & OSX
>Description:
Here is the message I get:
*** glibc detected *** pr-edit: munmap_chunk(): invalid pointer: 0xbfe657b0 ***
======= Backtrace: =========
/lib/libc.so.6(__libc_free+0x17b)[0x94f51f]
pr-edit[0x804e1e9]
pr-edit[0x804a601]
/lib/libc.so.6(__libc_start_main+0xdc)[0x8fd7e4]
pr-edit[0x8049b21]
======= Memory map: ========
>How-To-Repeat:
Running pr-edit like so:
echo $val | pr-edit --reason=$reason --replace=$field $issue
>Fix:
I took out the free... which I know can't be the best solution.

--- edit.c.fix  2006-07-19 17:20:47.000000000 -0500
+++ edit.c.1    2006-07-19 16:29:34.000000000 -0500
@@ -1085,7 +1085,7 @@
       if (changeReason != NULL)
        {
          setFieldChangeReason (new_pr, fieldIndex, changeReason);
-         /* free (changeReason);*/
+         free (changeReason);
          changeReason = NULL;
        }
>Notify-List:    
>Unformatted: