[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[SCM] libgnokii and core programs branch, master, updated. rel_0_6_28-90
From: |
Daniele Forsi |
Subject: |
[SCM] libgnokii and core programs branch, master, updated. rel_0_6_28-90-gc51998b |
Date: |
Sat, 24 Oct 2009 16:22:26 +0000 |
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "libgnokii and core programs".
The branch, master has been updated
via c51998bff2f4779bdbd5bec08da7bb0bc93b8017 (commit)
via 5ae6061d314ea63f4a490ed3dbdef8841df70d01 (commit)
from 5368b7a484ec0b4a6b06f318935c090fe6ebd457 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit c51998bff2f4779bdbd5bec08da7bb0bc93b8017
Author: Daniele Forsi <address@hidden>
Date: Sat Oct 24 16:31:02 2009 +0200
Do not use getline()
It was overkill for reading a short string in a static buffer and our
replacement function didn't work as expected.
Also make get_password() conditional to the existence of getpass() instead
of
hardcoding platforms.
Also fix getpass() usage; output from valgrind when it returned NULL was:
valgrind gnokii/gnokii --phone fake --entersecuritycode PIN </dev/null
==31806== Conditional jump or move depends on uninitialised value(s)
==31806== at 0x40266EB: strlen (mc_replace_strmem.c:242)
==31806== by 0x427F6D7: vfprintf (in /lib/tls/i686/cmov/libc-2.9.so)
==31806== by 0x428061F: (within /lib/tls/i686/cmov/libc-2.9.so)
==31806== by 0x427BADD: vfprintf (in /lib/tls/i686/cmov/libc-2.9.so)
==31806== by 0x4337986: __fprintf_chk (in /lib/tls/i686/cmov/libc-2.9.so)
==31806== by 0x8058B5C: get_password (stdio2.h:98)
==31806== by 0x80594FE: entersecuritycode (gnokii-security.c:191)
==31806== by 0x804D0B4: parse_options (gnokii.c:1036)
==31806== by 0x804C60F: parse_options (gnokii.c:823)
==31806== by 0x804D1D1: main (gnokii.c:1190)
==31806==
==31806== Conditional jump or move depends on uninitialised value(s)
==31806== at 0x4026837: strncpy (mc_replace_strmem.c:291)
==31806== by 0x8058B72: get_password (string3.h:122)
==31806== by 0x80594FE: entersecuritycode (gnokii-security.c:191)
==31806== by 0x804D0B4: parse_options (gnokii.c:1036)
==31806== by 0x804C60F: parse_options (gnokii.c:823)
==31806== by 0x804D1D1: main (gnokii.c:1190)
commit 5ae6061d314ea63f4a490ed3dbdef8841df70d01
Author: Daniele Forsi <address@hidden>
Date: Sat Oct 24 16:06:49 2009 +0200
Move #include <io.h> in the source file containing read() which needs it
Comment it out like the block of code containing read().
The #include line was added in commit
0170c33ea4f083df6484f87309a25f2f361394d0
-----------------------------------------------------------------------
Summary of changes:
configure.in | 2 +-
gnokii/gnokii-monitor.c | 4 +++
gnokii/gnokii-security.c | 59 ++++++++++++++++++++-------------------------
gnokii/gnokii-utils.c | 15 -----------
gnokii/gnokii.c | 1 -
5 files changed, 31 insertions(+), 50 deletions(-)
hooks/post-receive
--
libgnokii and core programs
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [SCM] libgnokii and core programs branch, master, updated. rel_0_6_28-90-gc51998b,
Daniele Forsi <=