[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[SCM] libgnokii and core programs branch, master, updated. rel_0_6_29-42

From: Daniele Forsi
Subject: [SCM] libgnokii and core programs branch, master, updated. rel_0_6_29-424-g8760c15
Date: Sat, 05 Jan 2013 17:37:45 +0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "libgnokii and core programs".

The branch, master has been updated
       via  8760c15800d986b8b44b87d60a843d2e32176785 (commit)
      from  22b3fd7643d5af83a0be8c52d98855eabf801289 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit 8760c15800d986b8b44b87d60a843d2e32176785
Author: Daniele Forsi <address@hidden>
Date:   Sat Jan 5 18:31:07 2013 +0100

    Fix bitwise comparison bug found with coccicheck
    It worked because truth values are promoted to 0 and 1 and the only
    values currently used for flags are also 0 and 1, in fact it checked
    only the lsb and it would fail as soon as we add other flags.

diff --git a/common/gsm-sms.c b/common/gsm-sms.c
index b4240df..4ea8b62 100644
--- a/common/gsm-sms.c
+++ b/common/gsm-sms.c
@@ -846,7 +846,7 @@ gn_error gn_sms_pdu2raw(gn_sms_raw *rawsms, unsigned char 
*pdu, int pdu_len, int
        unsigned int l, extraoffset, offset = 0;
        int parameter_indicator;
-       if (!flags & GN_SMS_PDU_NOSMSC) {
+       if (!(flags & GN_SMS_PDU_NOSMSC)) {
                l = pdu[offset] + 1;
                if (l > pdu_len || l > GN_SMS_SMSC_NUMBER_MAX_LENGTH) {
                        dprintf("Invalid message center length (%d)\n", l);


Summary of changes:
 common/gsm-sms.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

libgnokii and core programs

reply via email to

[Prev in Thread] Current Thread [Next in Thread]