[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[SCM] libgnokii and core programs branch, master, updated. rel_0_6_29-42

From: Daniele Forsi
Subject: [SCM] libgnokii and core programs branch, master, updated. rel_0_6_29-426-ga5a1d28
Date: Sun, 13 Jan 2013 14:38:15 +0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "libgnokii and core programs".

The branch, master has been updated
       via  a5a1d280227a65ed64483755aa3ab976e68c67ab (commit)
      from  e9e03c1c3d8fc0bba4c5ed45c7687cac59311ac0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit a5a1d280227a65ed64483755aa3ab976e68c67ab
Author: Daniele Forsi <address@hidden>
Date:   Sun Jan 13 14:55:03 2013 +0100

    Avoid UDH buffer overrun caused by some FBUS frames
    Something is wrong with our decoding of subblock 0x80 in ParseLayout()
    for nk6510.c but we shouldn't overrun the static buffer in any case.
    Bug reported in the mailing list:

diff --git a/common/gsm-sms.c b/common/gsm-sms.c
index 4ea8b62..fb7291d 100644
--- a/common/gsm-sms.c
+++ b/common/gsm-sms.c
@@ -608,6 +608,10 @@ static gn_error sms_udh_decode(unsigned char *message, 
gn_sms_udh *udh)
                length -= (udh_length + 2);
                pos += (udh_length + 2);
+               if (nr == GN_SMS_UDH_MAX_NUMBER) {
+                       dprintf("WARNING: UDH buffer has space for %d elements; 
further elements will be ignored\n", GN_SMS_UDH_MAX_NUMBER);
+                       break;
+               }
        udh->number = nr;


Summary of changes:
 common/gsm-sms.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

libgnokii and core programs

reply via email to

[Prev in Thread] Current Thread [Next in Thread]