[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[SCM] libgnokii and core programs branch, master, updated. rel_0_6_29-43

From: Daniele Forsi
Subject: [SCM] libgnokii and core programs branch, master, updated. rel_0_6_29-433-g1e8ff8b
Date: Sun, 20 Jan 2013 17:36:06 +0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "libgnokii and core programs".

The branch, master has been updated
       via  1e8ff8b3c78d6f52e4a0750f34f121dd6e624189 (commit)
      from  dc50c42ed8552e2e5efbe16601c27360d11e7c5c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit 1e8ff8b3c78d6f52e4a0750f34f121dd6e624189
Author: Daniele Forsi <address@hidden>
Date:   Sun Jan 20 18:35:13 2013 +0100

    Fix warning when compiling with clang and fix fwrite() arguments order
    The return value of fwrite() is a size_t so it can't be negative.
    gnokii/gnokii-ringtone.c:219:50: warning: comparison of unsigned expression 
< 0 is always false [-Wtautological-compare]
                    if (fwrite(, 1, rawdata.length, f) < 0) {
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
    1 warning generated.

diff --git a/gnokii/gnokii-ringtone.c b/gnokii/gnokii-ringtone.c
index eeed5b6..273bdac 100644
--- a/gnokii/gnokii-ringtone.c
+++ b/gnokii/gnokii-ringtone.c
@@ -216,7 +216,7 @@ gn_error getringtone(int argc, char *argv[], gn_data *data, 
struct gn_statemachi
                        error = -1;
                        goto out;
-               if (fwrite(, 1, rawdata.length, f) < 0) {
+               if (fwrite(, rawdata.length, 1, f) < 1) {
                        fprintf(stderr, _("Failed to write ringtone.\n"));
                        error = -1;


Summary of changes:
 gnokii/gnokii-ringtone.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

libgnokii and core programs

reply via email to

[Prev in Thread] Current Thread [Next in Thread]