[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[SCM] libgnokii and core programs branch, master, updated. rel_0_6_29-48
From: |
Daniele Forsi |
Subject: |
[SCM] libgnokii and core programs branch, master, updated. rel_0_6_29-488-gb109381 |
Date: |
Wed, 24 Apr 2013 14:41:38 +0000 |
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "libgnokii and core programs".
The branch, master has been updated
via b1093814a5682b7fee56d214f78a8e07778d66d5 (commit)
from 9f8f70dbb7363ade19098aedd4710ff71d1a92f0 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/gnokii.git/commit/?id=b1093814a5682b7fee56d214f78a8e07778d66d5
commit b1093814a5682b7fee56d214f78a8e07778d66d5
Author: Daniele Forsi <address@hidden>
Date: Wed Apr 24 16:39:49 2013 +0200
Fix "Value stored to 'pos' is never read"
Error found with scan-build.
diff --git a/common/phones/nk7110.c b/common/phones/nk7110.c
index 737bca3..381d46a 100644
--- a/common/phones/nk7110.c
+++ b/common/phones/nk7110.c
@@ -2267,6 +2267,9 @@ static gn_error NK7110_IncomingWAP(int messagetype,
unsigned char *message, int
char_unicode_decode(data->wap_setting->sms_server_number, message + pos,
string_length);
dprintf(" Server number: %s\n",
data->wap_setting->sms_server_number);
pos += string_length;
+
+ if (length != pos)
+ dprintf("Unexpected frame length (expected %d
got %d)\n", length, pos);
break;
case 0x01:
dprintf("GSM data:\n");
@@ -2295,6 +2298,9 @@ static gn_error NK7110_IncomingWAP(int messagetype,
unsigned char *message, int
char_unicode_decode(data->wap_setting->gsm_data_password, message + pos,
string_length);
dprintf(" Password: %s\n",
data->wap_setting->gsm_data_password);
pos += string_length;
+
+ if (length != pos)
+ dprintf("Unexpected frame length (expected %d
got %d)\n", length, pos);
break;
default:
break;
-----------------------------------------------------------------------
Summary of changes:
common/phones/nk7110.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
hooks/post-receive
--
libgnokii and core programs
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [SCM] libgnokii and core programs branch, master, updated. rel_0_6_29-488-gb109381,
Daniele Forsi <=