Re: CVS updates

[Pawel Kot]

On Sun, 19 May 2002, Pavel Machek wrote:

> > * Pawel Kot writes:
> > > Hi,
> > > I'd like other developers, mainly phone drivers maintainers, to take a
> > > look at API. If you have any notes/suggestions/criticism about it, now
> > > it's the best time to tell about it. If nothing particular will happen
> > > I think the API may change only with minor detailes.
> >
> > It looks OK to me. In the end one has to write some function
> > FillRawSMS_IN, FillRawSMS_Pic and so on for the different message
> > types
>
> I though pictures are best done at PDU level...? Having duplicated
> code for pictures in each phone driver is certainly not good idea..

But these functions should be in SMS layer, not in the phone drivers.

> > for a phone, correct? Should I try to get 6510 working or work on 7110
> > code?
> >
> > > Currently implemented:
> > >  - reading of the PDU SMS; for the non-PDU SMS (3110 and 2110 series)
> > > another handling function is to be written
> > >  - 7110 driver is capable to read Inbox messages
>
> Is 7110 able to send?

With my changes the sending was completly cut out.

> > >  - gnokii.c is converted to use new API; other applications (xgnokii,
> > > smsd) are NOT converted yet.
>
> You seem to have done some major changes and some cleanups at the same
> time. Please avoid that in future, it makes porting harder.

Indeed. But separating it into 2 commits required too much work. But you
are right. It should be done in 2 steps. On the other hand I don't think
it may make porting harder as the cleanup touches only 7110 driver.

> Also it looks to me like sms handling will not be okay anytime soon
> (this will take a while to fix up). What about finally releasing 0.4.0
> (you wanted it at beggining of may, do you remember? ;-), and mark
> this 0.4.1-pre?
>
> 0.4.0 will lack ringtones and pictures, but we can certainly live with
> that, and if we document that properly, it is not a big deal.

At the moment we have 2 things broken:
 - SMS handling
 - xgnokii
Markus told me some time ago that he will have time to deal with xgnokii
this week. I hope to have some free time to deal with SMS this week too.
Indeed, ringtones and picture messages are not the showstopper. But I'd
like to have at least these things working:
 - AT/7110/6110 SMS reading and sending (at least basic types of the SMS)
 - xgnokii without serious known problems.

pkot
-- 
mailto:address@hidden :: mailto:address@hidden
http://kt.linuxnews.pl/ :: Kernel Traffic po polsku