[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Re: Encoding in atgen.c

From: Pawel Kot
Subject: Re: [PATCH] Re: Encoding in atgen.c
Date: Mon, 28 Jun 2004 00:09:47 +0200 (CEST)

On Sat, 26 Jun 2004, Hugo Haas wrote:

> I have implemented my encoding fix based on the data below:
> I have added an encode_everything boolean in the AT phone driver
> information. By default, it's set to 0, and is set to 1 for phones
> declaring themselves as "SONY ERICSSON". I believe that T610's need
> this to communicate with Gnokii, and it doesn't break the
> communication with the T68i.
> When drvinst->encode_everything is set, all strings between double
> quotes are encoded and decoded, i.e. names, phone numbers and memory
> types instead of just names.
> The patch is attached. It is essentially the patch I sent for 0.6.1[1]
> with its effects only applied to Sony Ericsson phones. Let me know if
> this is acceptable for inclusion.

You have changed the behaviour for the following functions:
 - at_memory_type_set()
 - AT_WritePhonebook()
 - ReplyReadPhonebook()
Are really only these functions affected? What about SMS functions? What
about divert functions? What about security codes?

And really, I'd *much* prefer to have it in ateric.c (instead of
encode_everything field).

And this is the last thing that stops me before releasing 0.6.2. There
were really lot of changes since the previous one, but I'd really like to
have SonyEricssons to work nicely with gnokii 0.6.2.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]