[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] 6310i ToDo writing improved

From: Pawel Kot
Subject: Re: [PATCH] 6310i ToDo writing improved
Date: Sun, 19 Dec 2004 01:55:47 +0100 (CET)

On Sun, 19 Dec 2004, Balint Reczey wrote:


> This patch hopefully fixes ToDo writing.
> The previous patch did not fix all problems, the phone
> appended memory random characters to todo texts even
> after patching.

Please use always diff -u format. It's much better readable. And now to
the code:
>                                 0x0E, /* length of text + 1*/
I need to test this on other phones. I didn't have such problems with my
6310 but will verify that.
>       req[10 + length ] = '\0';    // kind of padding
>       req[10 + length + 1] = '\0'; //
Looks ugly. Very ugly. Why do you need both fields zeroed? Perhaps it's
better to zero all req[] table. Or at least:
        req[10+length] = req[11+length] = 0;
looks much nicer.
>               free(req);
Looks very incorrect to me. req is allocated statically and I belive it
will segfault is most cases.

Otherwise it looks good. Will try it out.

p k o t a t b e z s e n s u d o t p l

reply via email to

[Prev in Thread] Current Thread [Next in Thread]