gnokii-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch] assume working unix98 PTYs


From: David Vrabel
Subject: [patch] assume working unix98 PTYs
Date: Tue, 11 Jan 2005 12:14:59 +0000
User-agent: Mozilla Thunderbird 0.9 (X11/20041124)

Hi,

It doesn't seem necessary to do configure time check for working UNIX98 PTYs. I would consider it sufficient to check for grantpt().

I considered making it a run time test but decided not to -- any reasonably recent system will have support for UNIX98 PTYs.

David Vrabel
--
David Vrabel, Design Engineer

Arcom, Clifton Road           Tel: +44 (0)1223 411200 ext. 3233
Cambridge CB1 7EA, UK         Web: http://www.arcom.com/
--- gnokii-0.6.4.orig/configure.in      Sun Oct 17 20:44:20 2004
+++ gnokii-0.6.4/configure.in   Tue Jan 11 12:00:32 2005
@@ -456,42 +456,7 @@
    [ win32="no"]
 )
 
-AC_CHECK_FUNC(grantpt,
-   [ AC_TRY_RUN([
-#define  _XOPEN_SOURCE 500
-
-#include <stdlib.h>
-#include <sys/types.h>
-#include <sys/stat.h>
-#include <fcntl.h>
-#include <unistd.h>
-
-int main()
-{
-       char *name = NULL;
-        int master, err;
-
-        master = open("/dev/ptmx", O_RDWR | O_NOCTTY | O_NONBLOCK);
-        if (master >= 0) {
-                err = grantpt(master);
-                err = err || unlockpt(master);
-                if (!err) {
-                        name = ptsname(master);
-                } else {
-                        exit(-1);
-                }
-        } else {
-               exit(-1);
-       }
-       close(master);
-       exit(0);
-}
-                ],
-                AC_DEFINE(USE_UNIX98PTYS),
-                AC_MSG_WARN("No unix98ptys"),
-               AC_MSG_WARN("Ensure to disable unix98ptys when crosscompiling"))
-   ]
-)
+AC_CHECK_FUNC(grantpt, AC_DEFINE(USE_UNIX98PTYS))
 
 AC_TRY_COMPILE( [#define _XOPEN_SOURCE 500
                 #include <sys/types.h>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]