[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnokii gtk2 port

From: Bastien Nocera
Subject: Re: [PATCH] gnokii gtk2 port
Date: Wed, 03 Aug 2005 11:44:44 +0100

On Tue, 2005-08-02 at 21:41 +0200, Pawel Kot wrote:
> Hi Bozo,
> 2005/8/2, BORBELY Zoltan <address@hidden>:
> > There are a lot of old code in gnokii which contain buffer overflow
> > errors. gnokii is evolving from an ordinary application to some kind
> > of server application, so we have to remove these errors from the code.
> > Maybe we have to redesign parts of the API to reach this goal...
> I'm a bit ashamed, but I really don't have enough time to design
> dcop/dbus daemon. I think it should be the first step in redesigning
> API. Development of the drivers is also important, but I'd rather have
> first a working daemon and then start to work on libgnokii2 (or
> whatever).

Even then, wouldn't this daemon just sit on top of libgnokii?

> > configure detects wheter C99 compatible snprintf() and vsnprintf()
> > implementation are available. gnokii will use a replacement function
> > if these functions aren't available or they aren't C99 compatible.
> > If there's no asprintf() or vasprintf() implementation, the snprintf
> > code provides them (look into common/snprintf.c). I think asprintf()
> > is the function you are looking for... :-)
> Bastien, is it enough for you?

snprintf still sucks in that you need a fixed-sized array to fit your
string, and that you're never sure whether you'll be able to fit the
whole string in it before actually doing it.

I don't see what the big deal is with using glib. It would mean less
code in gnokii (especially the convenience string functions), and glib
is available on all the platforms that gnokii can possibly run on (that
means all the Unices, MacOS X included, and Windows).

glib is also small enough that it is being used on PDAs and such.

Currently, only the code I'm writing is using glib, but I'd be happy
with modifying some of the existing code in gnokii to make use of the
glib functions when appropriate.

Bastien Nocera <address@hidden> 
"That Seaman is a handsome young man but he spends too much time looking
in his mirror rather than at the ball. You can't keep goal with hair
like that" - Brian Clough, on the pony-tailed former England goalkeeper
David Seaman.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]