[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: xgnokii segfaults on empty ringtones list

From: Daniele Forsi
Subject: Re: xgnokii segfaults on empty ringtones list
Date: Sat, 31 Dec 2005 13:41:35 +0100
User-agent: Mozilla Thunderbird 1.0.7 (X11/20050923)

Pawel Kot wrote:

You mean the ringtone doesn't get changed?

yes, and I hear no sound and there is no visual feedback

but if I load an rttl ringtone from file and hit play I hear it and the
piano keys do change color

So you mean it is empty because libgnokii cannot decode stored ringtones, right?

yes, this is what I meant, but now I see two problems:
get_ringtone_list() in common/phones/nk6100.c supports only 61xx and 51xx, returning GN_ERR_NOTIMPLEMENTED for others, but in init_ringtone_list() of gnokii/gnoikii.c this error code is not saved, instead a -1 for failure is saved in the variable ringtone_list_initialised and subsequent functions check this variable resulting in the more generic message "Failed to get the list of ringtones"

ringtones cannot be decoded by libgnokii when read one by one

At the moment --getringtonelist is pretty useless at least in this driver (nk6100.c) because the list is hardcoded in the library. These are monophonic ringtones and you shouldn't waste your time on this matter, but you could add somewhere in the docs that

the driver for the 6100 family supports these handsets
but --getringtonelist is currently implemented only for 51xx and 61xx


reply via email to

[Prev in Thread] Current Thread [Next in Thread]