[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: g_malloc / g_strdup in xgnokii_lowlevel.c

From: Pawel Kot
Subject: Re: g_malloc / g_strdup in xgnokii_lowlevel.c
Date: Tue, 21 Feb 2006 22:15:03 +0100


On 2/21/06, Daniele Forsi <address@hidden> wrote:
> and so I removed the two and two more, then it seems that the logic
> behind the assignment to is broken since it
> is a duplicate of revision in the first place (see my first post quoted
> above!).


> Below is my proposed change, deleting the g_malloc()'s and adding a
> g_strdup() to copy the string such as "NHM-6" as "version", so the
> options dialog is ok (it has max length 7 for
> hinting that a short string like that was
> expected) and the debug lines print

Looks fine. Seems that nobody pays much attention to it ;-) Would you commit?

Pawel Kot

reply via email to

[Prev in Thread] Current Thread [Next in Thread]