[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: smsd problem with AT model - Part II

From: Pawel Kot
Subject: Re: smsd problem with AT model - Part II
Date: Fri, 6 Oct 2006 12:22:12 +0200


On 10/6/06, Daniele Forsi <address@hidden> wrote:
Pawel Kot wrote:
> Please see the following patch (hope gmail doesn't mangle it).

long lines were wrapped (in my patch too) and it seems you can't configure
gmail to not do it
I thought that mail programs did not change tabs to spaces (patch -l to get
around this), better use attachments next time

Or send it from another mailing program. I prefer inlined patches as I
can comment them "live".

>+               sprintf(req, "AT+CPMS=\"%s\"\r", memorynames[mt]);
>                ret = sm_message_send(23, GN_OP_Init, req, state);

we need to change number of bytes to send from 23 to 13

Good point. I haven't tested the patch.

> -       data->sms_status->new_message_store = GN_MT_ME;

> -                       data->sms_status->new_message_store = i;

struct member new_message_store was used only here so it can
be deleted from ./include/gnokii/sms.h

typedef struct {
        /* Message store used for new received messages (this is used
         * internally by AT_SetSMSMemoryType() in common/phones/atgen.c). */
        gn_memory_type new_message_store;
} gn_sms_status;

Yes. I wanted to do this when it turns out that our new way works.

take care,
Pawel Kot

reply via email to

[Prev in Thread] Current Thread [Next in Thread]