[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Nokia 6155 on Gentoo 2006.1 with Gnokii 0.6.14 - some progress

From: Mark Kirkwood
Subject: Re: Nokia 6155 on Gentoo 2006.1 with Gnokii 0.6.14 - some progress
Date: Sun, 17 Dec 2006 13:01:00 +1300
User-agent: Thunderbird (X11/20061129)

Pawel Kot wrote:

No. The driver is not actively maintained as it is less reliable than
libusb driver.
And Linux policy is to change internal structures frequently so
maintaining any driver outside the main tree is IMHO nightmare.

Understood, they sure change fast and often!

# make
make[1]: Entering directory `/usr/src/linux-2.6.17-gentoo-r8'
   CC [M]  /root/gnokii-0.6.14/patches/kernel_2.6/nokia_dku2.o
/root/gnokii-0.6.14/patches/kernel_2.6/nokia_dku2.c:163: error: expected
')' before string constant

the line is:

MODULE_PARM(debug, "i");

and I can't actually see anything wrong with it (MODULE_PARM is defined
in linux/module.h which *is* included)...

Perhaps it uses just one parameter right now?

A second look shows that I was misled by a sea of MODULE_XXX_YYY defines. We need module_param(var, type, perms), with 3 args instead (see patch attached).

I'll test drive it later, when I boot into 2.6.17 (but it sounds like I should concentrate on the libusb approach - right? - since this will never work in 2.6.18....)



*** nokia_dku2.c.orig   Sun Dec 17 12:53:47 2006
--- nokia_dku2.c        Sun Dec 17 12:52:46 2006
*** 161,165 ****
! MODULE_PARM(debug, "i");
  MODULE_PARM_DESC(debug, "Debug enabled or not");
--- 161,165 ----
! module_param(debug, int, S_IRUGO);
  MODULE_PARM_DESC(debug, "Debug enabled or not");

reply via email to

[Prev in Thread] Current Thread [Next in Thread]