[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add gn_phonebook2vcardstr()

From: Daniele Forsi
Subject: Re: [PATCH] Add gn_phonebook2vcardstr()
Date: Fri, 13 Jun 2008 22:36:24 +0200

2008/6/13 Bastien Nocera wrote:

> But here's a patch to add a function to transform phonebook entries into
> a string, instead of just pushing it to a file descriptor.

there is similar code in common/gsm-sms.c used only by gn_sms2mbox(),
except the 75 chars limit (it should be 78 for RFC-2822 messages, but
may be up to 998, I don't know about mbox), maybe the same code can be
used in both places

I see that I made a weird thing when adding \r in
I removed \n from format strings and added \r\n to the replacement of fprintf()

the only excuse is that this way I don't risk splitting \r\n pairs in the middle
I wonder if we should use proper format strings and split only if 76th
char is neither \r nor \n
Daniele Forsi

reply via email to

[Prev in Thread] Current Thread [Next in Thread]