[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Using smsd to send multiline sms

From: Pawel Kot
Subject: Re: [PATCH] Using smsd to send multiline sms
Date: Fri, 18 Jul 2008 16:09:24 +0200


On Fri, Jul 18, 2008 at 16:00, Jan Derfinak <address@hidden> wrote:
> This is fix for existing bug in smsd. The patch which add multiline SMS
> support will be in next mail. In general it is not good practice to mix bug
> fixes with new features in one CVS commit.

Yes. You're absolutely right.

> Please review this patch as bugfix to existing functionality.

IMHO memsets are not needed.
I'd also use construction (it's not needed if fgets() in case of
failure sets NULL as the string -- I cannot see this guaranteed in the
if (!fgets(...)) {
    sms.something[0] = '\0';
slen = ....

Pawel Kot

reply via email to

[Prev in Thread] Current Thread [Next in Thread]