[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gnokii-0.6.30 patch

From: Pawel Kot
Subject: Re: gnokii-0.6.30 patch
Date: Wed, 19 Oct 2011 10:28:51 +0200


On Wed, Oct 19, 2011 at 09:07, root <address@hidden> wrote:
> I have to use this patch for smsd not to fail by incorrect memory reference,
> also I have added another line to select a driver for my phone.

Thanks for the patch, but please check the git version of gnokii. It
should have most of the parts fixed.

-       if (data->sms->parts == 0) {
+       if (data->sms->parts == 0 || !data->sms->reference) {

This part is rewritten in git.

+       {"2700 classic",  "RM-561",     PM_DEFAULT_S40_3RD },

I'll take this one.

--- gnokii-0.6.30/common/phones/nk6510.c        2011-01-23 17:27:32.000000000 
+++ gnokii-0.6.30+/common/phones/nk6510.c       2011-03-11 14:02:25.000000000 
+               if(!data->message_center)
+                       data->message_center = calloc(1, 

No, I want to avoid it. If (!data->message_center) it should exit with
error in this place. It is a responsibility of the caller to allocate

     free (dt->message_center);
+    dt->message_center = 0;

I'd prefer NULL instead of 0. But that should not matter actually. We
allocate the structure unconditionally.

   free (dt->sms->reference);
+  dt->sms->reference=0;
+  dt->sms->parts=0;
   free (dt);

Does not make sense as we free() it right after.

Can you please disclose your name for the changelogging purposes?

Pawel Kot

reply via email to

[Prev in Thread] Current Thread [Next in Thread]