gnokii-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

writephonebook fix + MyX-2 support


From: Raphaël
Subject: writephonebook fix + MyX-2 support
Date: Fri, 8 Mar 2013 00:46:49 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

Hi,

when using --writephonebook, both vCard and ldif parsers returns at the
end of file (as every file has an end), but the return value is treated
as GN_ERR_WRONGDATAFORMAT by writephonebook().
Thus after multiple entries have been written, a failure message appears after
the very last entry (successfully) stored.
Moreover, as the location integer changes meanwhile, the warning does not
reference a useful location.

This patch attempt to fix this by skipping entirely this warning
which is (always ?) wrong in the first place.



Side note: I got useful working features with the good old Sagem MyX-2
(no-slider model = no breakage).
Tips are documented here [1] though nothing really new as this model
was already supported by gammu.
But media AT commands (of limited use in these models) seem
proprietary and WAP has not been tested.


Unrelated question: is there any existing plan to enhance the
"find-free" option of writephonebook ?
It's a pain to use as it starts the location counter back to 2 for each
entry. So in the best case `--writephonebook -f` ends up testing 85!
(factorial) locations in order store 85 entries.
Trying (prev_entry_location + 1) could be a best guess to try before
going into this costly loop.




regards



[1] http://wiki.gnokii.org/index.php/Sagem_MyX-2

Attachment: writephonebook-eof.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]