[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 5/8] Test for number of mkdir() arguments

From: Ladislav Michl
Subject: Re: [PATCH 5/8] Test for number of mkdir() arguments
Date: Mon, 3 Dec 2018 23:02:37 +0100
User-agent: Mutt/1.10.1 (2018-07-13)

On Tue, Dec 04, 2018 at 12:24:14AM +0300, Pawel Kot wrote:
> Hi Ladis,
> On Mon, Dec 3, 2018 at 11:28 PM Ladislav Michl <address@hidden> wrote:
> > there's an issue with changes like that one bellow.
> > Currently each file including compat.h have to include
> > config.h before on its own. That does not sound too
> > convenient and is quite error prone as I just found
> > testing mkdir patch on more configurations.
> I remeber it being discussed. Still not quite sure why we did it that way.
> I believe #include "config.h" from compat.h should be safe. Even without
> removing all others. I believe that whenever you need something from
> "config.h" you should explicitly include it.

Well, I removed only those config.h includes added to satisfy compat.h.
IMHO code looks a bit saner with that change. Also minor Makefile
change was needed not to eat -DHAVE_CONFIG_H in subdirs. Two patches
follows. Please note that they make this patchset obsolete and I'll
resend it with more fixes later.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]