[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] Include config.h from compat.h

From: Ladislav Michl
Subject: Re: [PATCH 2/2] Include config.h from compat.h
Date: Mon, 13 Jan 2020 20:52:46 +0100


On Mon, Jan 13, 2020 at 08:02:48PM +0100, Pawel Kot wrote:
> Hi,
> On Mon, Dec 3, 2018 at 11:12 PM Ladislav Michl <address@hidden> wrote:
> >
> > compat.h configuration depends on defines from config.h, however
> > it does not include it. Explicitely include config.h and remove
> > it from all files which did so only to satisfy compat.h
> > configuration.
> It was a decision at some moment that we want to include
> explicitly config.h from all source files where it is actually needed. And
> we knew to include config.h before compat.h.

Let me put your own quotation here:
Subject: Re: [PATCH 5/8] Test for number of mkdir() arguments
On Tue, Dec 04, 2018 at 12:24:14AM +0300, Pawel Kot wrote:
> On Mon, Dec 3, 2018 at 11:28 PM Ladislav Michl <address@hidden> wrote:
> > there's an issue with changes like that one bellow.
> > Currently each file including compat.h have to include
> > config.h before on its own. That does not sound too
> > convenient and is quite error prone as I just found
> > testing mkdir patch on more configurations.
> I remeber it being discussed. Still not quite sure why we did it that way.
> I believe #include "config.h" from compat.h should be safe. Even without
> removing all others. I believe that whenever you need something from
> "config.h" you should explicitly include it.

Here I agree with you. Now it is up to you to come to the conclusion with
yourself ;-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]