[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: devices: pass gn_config to open and following devices: *: use instan
Re: devices: pass gn_config to open and following devices: *: use instance data commits
Sun, 09 Jan 2022 22:09:27 +0100
Ah, I see now.
I was unsure about removing gn_config entirely, so I decided to pass it
as parameter. After all it is device configuration, so I guess it does
usbfbus_find_interfaces by its name just finds interface, no need to
clutted it with unrelated stuff...
From: Pawel Kot <firstname.lastname@example.org>
To: Ladislav Michl <email@example.com>
Cc: Ladislav Michl <firstname.lastname@example.org>, Discussion forum for gnokii
Subject: Re: devices: pass gn_config to open and following devices: *:
use instance data commits
Date: Sun, 9 Jan 2022 22:01:37 +0100
Thanks. Let me look into preview5 shortly then.
Why bother with gn_config then? As far as I can see all drivers use
just ->port_device. (Plus two more by bluetooth). So perhaps let's
kill this dependency as well?
I mean this part:
You have moved the n = atoi(cfg->port_device) portion from one function
to the other.