Re: [Gnu-arch-users] DAV login problem (and a fix)

[Tom Lord]

    > From: Yasushi Saito - at home <address@hidden>

    [diff forwarded to list]


I realize that it is somewhat inconvenient but will you please
submit this as a bug report on savannah?

There is a field for bugs where you can say "diff included" and that
makes sure that it isn't lost in mailing list traffic.   (Of course, 
publishing it in arch archive is even better but minimally, please
make the database entry.)

Rob or someone might pick it up anyway but, based on my experience, I
discourage that.  It saves maintainers a lot of potential bookkeeeping
and headache in the long run to have a simple rule that patches (even
if forwarded to the list, which can be quite useful) go through the
database.

(And Rob, if you do merge this, please review it carefully.   I'm sure
it's fine -- it's just worth sanity checking the usual snafus and
snafu-corrections of string processing foo.  WebDAV access "works fine
for me" and many others -- so let's not break it.)

Thanks,
-t

p.s. to rob: haven't gotten back to you on process foo.   Sorry. 
     Let's wing it but: clean changesets that I can replay one at
     a time would be swell.   After the first iteration of merging 
     from you, if all goes well enough, remind me to figure out how
     to give you admin access to the issue db.





    > User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
    >   rv:1.5b) Gecko/20030901 Thunderbird/0.2
    > X-Accept-Language: en-us, en
    > Cc: address@hidden
    > Content-Type: text/plain; charset=ISO-8859-1; format=flowed
    > X-BeenThere: address@hidden
    > X-Mailman-Version: 2.1.2
    > Precedence: list
    > List-Id: a discussion list for all things arch-ish  
<gnu-arch-users.gnu.org>
    > List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/gnu-arch-users>,
    >   <mailto:address@hidden>
    > List-Archive: <http://mail.gnu.org/pipermail/gnu-arch-users>
    > List-Post: <mailto:address@hidden>
    > List-Help: <mailto:address@hidden>
    > List-Subscribe: <http://mail.gnu.org/mailman/listinfo/gnu-arch-users>,
    >   <mailto:address@hidden>
    > Sender: address@hidden
    > X-Spam-Checker-Version: SpamAssassin 2.60 (1.212-2003-09-23-exp) on 
    >   mail.42inc.com
    > X-Spam-DCC: : 
    > X-Spam-Status: No, hits=-4.9 required=4.5 tests=BAYES_00 autolearn=ham 
    >   version=2.60
    > X-UIDL: 288fbbe79634caadad38494ea0c9e10e
    > 
    > I noticed today that the DAV interface isn't usable. Without getting 
    > into too much detail, here's my fix.
    > (The problem was that the user name and password weren't always 
    > zero-terminated.)
    > 
    > yaz
    > 
    > *** src/tla/libarch/pfs-dav.c~  Thu Oct 23 15:44:28 2003
    > --- src/tla/libarch/pfs-dav.c   Tue Nov 18 20:33:54 2003
    > ***************
    > *** 709,717 ****
    > 
    >     auth = userdata;
    >     len = str_length (auth->username);
    > !   str_cpy_n (username, auth->username, MIN (len, NE_ABUFSIZ - 1));
    >     len = str_length (auth->password);
    > !   str_cpy_n (password, auth->password, MIN (len, NE_ABUFSIZ - 1));
    > 
    >     return 0;
    >   }
    > --- 709,717 ----
    > 
    >     auth = userdata;
    >     len = str_length (auth->username);
    > !   str_cpy_n (username, auth->username, MIN (len + 1, NE_ABUFSIZ - 1));
    >     len = str_length (auth->password);
    > !   str_cpy_n (password, auth->password, MIN (len + 1, NE_ABUFSIZ - 1));
    > 
    >     return 0;
    > }
    > 
    > 
    > 
    > 
    > 
    > 
    > 
    > _______________________________________________
    > Gnu-arch-users mailing list
    > address@hidden
    > http://mail.gnu.org/mailman/listinfo/gnu-arch-users
    > 
    > GNU arch home page:
    > http://savannah.gnu.org/projects/gnu-arch/
    > 
    >