Re: [Gnu-arch-users] [BUG] serious bug in vu_write_retry?

[Jeremy Shaw]

At Fri, 9 Jul 2004 08:09:06 -0700 (PDT),
Tom Lord wrote:
> 
> 
>     > From: Jeremy Shaw <address@hidden>
> 
>     > --- orig/vu/vu.c
>     > +++ mod/vu/vu.c
>     > @@ -1241,8 +1241,11 @@
>     >         return amt;
>     >        if (amt == count)
>     >         return orig_count;
>     > -      count -= amt;
>     > -      buf += amt;
>     > +      if(amt > 0 )
>     > +        {
>     > +          count -= amt;
>     > +          buf += amt;
>     > +        }
>     >      }
>     >  }
> 
> Ouch.   Amazing how long that's been there.

Agreed, that is why we had a hard time believing it was really a bug.

> I think this is clearer:
[snip]

Agreed. The above patch was the simpliest way to demonstrate the
change in behaviour we wanted -- but it is clearly not the best way to
implement it.

> (and will be pushed soon (modulo consideration of abentley's
> alternative return value proposal)).

Sounds good!

Jeremy Shaw.