[Gnu-arch-users] [BUG] botched invariant when running make-archive

[James Blackwell]

User Name: Joe
email: address@hidden

entered the following command:
  tla make-archive address@hidden 2004-archive-name

And ended up with a botched invariant:

  /path/tla-1.2/src/tla/libarch/pfs-fs.c:87:botched invariant
  !!uri
  PANIC: exiting on botched invariant


The problem is that the user entered a relative path. For example, he
typed 2004-archive-name instead of /home/joe/archives/2004-archive-name.


Apparently, arch_pfs_fs_connect (t_uchar * uri) is getting passed a null
because make-archive was passed a relative path. The proper fix for this
bug isn't to change the botched invariant, but to do some sanity checks
earlier in the code.

What's called for in this case is first to trace the code and find where
exactly the user given uri is getting turned into a null (I suspect
wherever the code decides which pfs module to use), and then tell the user
something like: 

Invalid uri given. If you meant to use a local directory, 
use a full path instead of a relative path.

-- 
James Blackwell          Try something fun: For the next 24 hours, give
Smile more!              each person you meet a compliment!

GnuPG (ID 06357400) AAE4 8C76 58DA 5902 761D  247A 8A55 DA73 0635 7400