[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnu-arch-users] arch_pfs_checksum_governs_strictly useless complica

From: James Blackwell
Subject: Re: [Gnu-arch-users] arch_pfs_checksum_governs_strictly useless complicated?
Date: Wed, 25 Aug 2004 14:06:31 -0400

Jivera wrote:
> which is basically long hand for "signed_archive || check_rule".
> However, this routine is only called by pfs_revision_type and only
> after arch_pfs_ensure_checksum_data successfully returns.  Further,
> one of it's failure conditions is:
> So by time we get to arch_pfs_checksum_governs_strictly we know this
> condition must be false.  Therefor (someone double check my logic):
> So, does anyone see a reason not to change this code to
>     int
>     arch_pfs_checksum_governs_strictly (struct arch_pfs_archive * arch)
>     {
>       return arch->arch.signed_archive;
>     }

Reading your description, I don't see a reason to keep it. Anybody else
have an opinion?

James Blackwell          Try something fun: For the next 24 hours, give
Smile more!              each person you meet a compliment!

GnuPG (ID 06357400) AAE4 8C76 58DA 5902 761D  247A 8A55 DA73 0635 7400

reply via email to

[Prev in Thread] Current Thread [Next in Thread]