Re: [Gnu-arch-users] [BUG] New bug report for 1k barrier PANIC

[James Blackwell]

On Tue, Aug 31, 2004 at 01:30:04PM +1000, Robert Collins wrote:
> On Mon, 2004-08-30 at 21:08 -0500, Robert Anderson wrote:
> > '
> > % echo "// arch-tag: blah" > file
> > % /home/rwa/linux-packages/tla-1.2.1/bin/tla inventory
> > S  file
> > % echo -n "// arch-tag: blah" > file
> > % /home/rwa/linux-packages/tla-1.2.1/bin/tla inventory
> > PANIC: Top-of-file arch tag crosses 1k boundary
> > '
> 
> Ok thats a clear demonstration of the bug. If its not fixed (and I
> suspect it already has been by someone), I'll dig into it, erm, thursday
> at my current schedule.
> 

Actually, this looks to be a second bug thats shown off by the panic.
Jivera found what looks like an off-by-one error in the buffer handler.

It looks like if A) The file is less than 1026 characters and B)
There is only one newline after the tag, then the old code looses the
return. 

Take a look: 

inv-ids.c ~ 1385:
  if (0 > vu_lseek (errn, file_fd, -1026, SEEK_END))
      goto error_return;

This looks like it should be this instead: 

  if (0 > vu_lseek (errn, file_fd, - sizeof(buff), SEEK_END))
      goto error_return;


I plan on testing this today. Then, I need to review Jani Monoses'
patches. Depending on how long Jani takes, I may be able to release
1.2.2rc1 today or tomorrow.



-- 
James Blackwell          Try something fun: For the next 24 hours, give
Smile more!              each person you meet a compliment!

GnuPG (ID 06357400) AAE4 8C76 58DA 5902 761D  247A 8A55 DA73 0635 7400