[Gnu-arch-users] [UPDATE: merge-57] Update automatic changelog id validation to common behavior (optimized)

[Yann Droneaud]

Archive-URI: http://sherkan.tuxfamily.net/~meuh/arch/address@hidden/
Base-Revision: address@hidden/tla--devo--1.3--patch-32
Revision: 
address@hidden/tla--automatic-changelog-tag--1.3--patch-1,address@hidden/tla--automatic-changelog-tag--1.3--patch-2,address@hidden/tla--automatic-changelog-tag--1.3--patch-3
Bug: 66

patch-1
    update automatic changelog id validation to common behavior
patch-2
    Removed unused regexp
patch-3
    Use string functions instead of regexp

- Short description:
In libarch/changelogs.c, 
use library functions arch_valid_package_name() and
arch_parse_package_name() to validate automatic changelog tag.

This make automatic changelog share the same validator
as other parts of tla, and works against any valid version name.

This should close bug 66.not-so-auto-changelogs:
http://bugs.gnuarch.org/cgi-bin/bugreport.cgi?bug=66

- Update:
In libarch/changelogs.c:

Added a changelog id prefix string constant.

Use strings functions instead of a regexp to check
automatic changelog id in arch_id_changelog_package_name().

Removed changelog_id_pattern()

Use the new constant in arch_generate_changelog().

- Test:
I wasn't able to find any regression. 
I made many tests with various strange tags, correct or incorrects.
The only difference is about single number version, but this is what we
what. 


Feel free to comment, update, merge, but don't ignore ;)

Regards.

-- 
Yann Droneaud (aka Meuh) <address@hidden>
http://meuh.org/ | http://sherkan.tuxfamily.net/~meuh/
Une vache perdue sur Internet | A cow lost in the Internet
1024D/BEA43321   5D91 B5B0 5137 B8FE 6882  FE19 CAA0 6F05 BEA4 3321