[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnu-arch-users] --forward mostly harmless

From: Phil Frost
Subject: Re: [Gnu-arch-users] --forward mostly harmless
Date: Mon, 13 Sep 2004 13:50:44 -0400
User-agent: Mutt/1.5.6+20040722i

I think this just applies to normal diffs, that is, not unidiff, because
it has no context.

On Mon, Sep 13, 2004 at 07:38:41PM +0200, David Allouche wrote:
> I have not thought much about the potential failure modes of that
> approach, but it did press a red button.
> >From the "Applying Reversed Patches" info page:
>         This method cannot detect a reversed patch if it is a normal
>         diff and the first command is an append (which should have been
>         a delete) since appends always succeed, because a null context
>         matches anywhere.  But most patches add or change lines rather
>         than delete them, so most reversed normal diffs begin with a
>         delete, which fails, and `patch' notices.
> At least, the approach you propose will cause deletes to always be
> ignored. Well, maybe we do need something smarter than patch(1).
> It the meantime, let us just delete the --forward option. It's cruft.
> -- 
>                                                             -- ddaa

reply via email to

[Prev in Thread] Current Thread [Next in Thread]