[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnu-arch-users] [BUG] pika escaping corrupts taglines containing "

From: Tom Lord
Subject: Re: [Gnu-arch-users] [BUG] pika escaping corrupts taglines containing "
Date: Wed, 15 Sep 2004 14:47:48 -0700 (PDT)

    > From: address@hidden

    > Bugfix idea:

    > make an arch_cmp_ids (alloc_limits, t_uchar*, t_uchar*) function and use
    > that everywhere to compare ids.

Doesn't that violate the abstractions you introduced?

Escaping/unescaping is supposed to happen at write/read time and,
internally, str_cmp should be fine.

If there are historic revisions that contain unescaped " characters,
then perhaps that could be fixed in the unescaping engine?

After all: if the input string to unescaping is improperly escaped in
some historic cases -- that's terrific!   That can be detected and
treated as a special case for unescaping.

(A tla-specific wrapper around the hackerlab unescaping code would be
fine for this, so long as we are no longer generating improperly
escaped data.   That will help keep the hackerlab code clean and it is
only tla that needs this special case.)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]