[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: New version of undo-tree.el

From: Toby Cubitt
Subject: Re: New version of undo-tree.el
Date: Tue, 12 Jan 2010 22:34:35 +0100
User-agent: Mutt/1.5.20 (2009-06-14)

On Tue, Jan 12, 2010 at 05:39:04AM -0800, Vegard Øye wrote:
> thank you so much for writing undo-tree.el. I have been using it for
> some days now, and it just feels ontologically right: undo history
> /is/ a tree, as everyone who has used a version control system knows.
> Indeed, the package is essentially a miniature VCS for buffer states!

Indeed, although I should point out that I have no intention of extending
it to anything remotely approaching a full VCS. There are full VCS's for
that ;-)

> There is a slight problem when using it together with Gascoigne's
> Windows port of gnuserv.el, whose redefinition of `kill-buffer' needs
> an explicit argument. The following patch fixes the problem:
> @@ -1695 +1695 @@
> -  (kill-buffer))
> +  (kill-buffer (current-buffer)))

This was also broken in Emacs-22, and I've just pushed a change to the
repository that passes a null argument to kill-buffer. In Emacs-22, a
null argument kills the current buffer. Does the Windows port you're
talking about also understand a null argument, or does it really require
passing current-buffer?

Just to warn anyone using undo-tree-mode, for now my focus with undo-tree
is to finish implementing missing features (like supporting marker
adjustments, and implementing undo-in-region), so I haven't put any
effort into checking compatibility with anything other than the version
of Emacs I happen to use (a recent VCS build). In other words, there may
well be more compatibility bugs along these lines. Once I feel that the
undo-tree code is relatively stable, I'll put some effort into
systematically going through it and checking compatibility with older
Emacs versions.

Of course, you're still welcome to report any compatibility bugs you do
encounter (probably best to do so off-list), and I'll try to push fixes
if they're not too complicated.


Dr T. S. Cubitt
Quantum Information Theory group
Department of Mathematics
University of Bristol
United Kingdom

email: address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]