Re: volta spanner in 1.3.92 still broken

[Roy . Rankin]

I recently discovered that although the following patch seemed to fix
the original complaint that it causes other problems (the following
tests were done in 1.3.116.

I have attached a file which has several break-volta interactions.

With the test file and unmodified 1.3.116 I see the following:

Bar 3 - 1st volta spanner centered on first note - prefer it to start
        closer to key signature (can live with this)
Bar 6 - 1st volta continuation - perfect
Bar 9 - 2nd volta spanner starts on left edge of key signature - prefer
        it to start right of key signature
Bar 12  1st volta starts between first two slurred notes in measure -
        this is not acceptable
Bar 17  like above with hairpin.
Bar 23  like above (I had expected this to be OK)
Bar 20  2nd volta continuation perfect

With the test file and 1.3.116 modified as below I see the following:

Bar 3   Perfect
Bar 6   1st volta continuation starts with staff - oops
Bar 9   2nd volta starts on papers left margin - OOPS!
Bar 12  Perfect
Bar 17  Perfect
Bar 20  2nd volta continuation starts with staff - oops
Bar 23  Perfect



On  3 Oct, Han-Wen Nienhuys wrote:
> address@hidden writes:
>> 
>> The problem with volta spanner starting in middle of a measure (after
>> line break?) which I reported some time ago is still broken in 1.3.92.
> 
> Try the attached patch. It puts the start of the volta spanner
> directly after the key signature (but before a time-signature, if
> there is a time-signature change).  I'm not sure where the correct
> starting point is, though. I'll have a look in the books when I have
> time. In the meantime.
> 
> 
> 
> --- volta-spanner.cc~ Sat Sep 23 01:45:48 2000
> +++ volta-spanner.cc  Tue Oct  3 13:15:06 2000
> @@ -66,7 +66,12 @@
>    Real staff_space = me->paper_l ()->get_var ("staffspace");
>    Real staff_thick = me->paper_l ()->get_var ("stafflinethickness");  
>    Real half_space = staff_space / 2;
> -  Real left = dynamic_cast<Spanner*>(me)->get_broken_left_end_align ();
> +
> +  /*
> +    the volta spanner is attached to the bar-line, which is moved
> +    to the right. We don't need to compensate for the left edge.
> +   */
> +  Real left = 0.0;
>    Real w = dynamic_cast<Spanner*>(me)->spanner_length () - left - half_space;
>    Real h = staff_space * gh_scm2double (me->get_elt_property ("height"));
>    Real t = staff_thick * gh_scm2double (me->get_elt_property ("thickness"));
>

qq.ly
Description: volta break interations