[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[gnuastro-commits] master 48236cfe: Tests (psf-select-stars): not keepin

From: Mohammad Akhlaghi
Subject: [gnuastro-commits] master 48236cfe: Tests (psf-select-stars): not keeping temporary directory
Date: Tue, 28 Mar 2023 09:30:57 -0400 (EDT)

branch: master
commit 48236cfe6ddd691c299de155a66a18672cb8aebf
Author: Mohammad Akhlaghi <>
Commit: Mohammad Akhlaghi <>

    Tests (psf-select-stars): not keeping temporary directory
    Until now, the test for 'astscript-psf-select-stars' was being executed
    with the '--keeptmp' option! As a result, when 'make distcheck' was run, it
    would complain about undeleted files!
    With this commit, by removing the '--keeptmp' option from the test of this
    script the problem was solved.
    This bug was reported by Siyang He as part of task #16114.
    This fixes bug #63969.
 NEWS                             | 2 ++
 THANKS                           | 1 +
 doc/announce-acknowledge.txt     | 1 +
 tests/script/ | 2 +-
 4 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/NEWS b/NEWS
index c914bf91..9cbc6348 100644
--- a/NEWS
+++ b/NEWS
@@ -365,6 +365,8 @@ See the end of the file for license conditions.
               by Nafiseh Sedighi.
   bug #63543: Programs delete input when it has same name as output.
               Reported by Faezeh Bidjarchian.
+  bug #63969: make distcheck error due to temporary files of
+              astscript-psf-select-stars. Reported by Siyang He.
diff --git a/THANKS b/THANKS
index 71ec8689..4a400ff7 100644
--- a/THANKS
+++ b/THANKS
@@ -60,6 +60,7 @@ support in Gnuastro. The list is ordered alphabetically (by 
family name).
     Madusha Gunawardhana       
     Bruno Haible               
     Stephen Hamer              
+    Siyang He                  
     Zahra Hosseini             
     Leslie Hunt                
     Takashi Ichikawa           
diff --git a/doc/announce-acknowledge.txt b/doc/announce-acknowledge.txt
index 7e5eb3ca..ab8860ea 100644
--- a/doc/announce-acknowledge.txt
+++ b/doc/announce-acknowledge.txt
@@ -6,6 +6,7 @@ Fernando Buitrago
 Sepideh Eskandarlou
 Zohreh Ghaffari
 Giulia Golini
+Siyang He
 Martin Kuemmel
 Teet Kuutma
 Samane Raji
diff --git a/tests/script/ b/tests/script/
index e89add9b..76470a7a 100755
--- a/tests/script/
+++ b/tests/script/
@@ -82,4 +82,4 @@ $check_with_program $execname $fits1name --hdu=1 \
                               --mindistdeg=0.05 \
                               --matchaperturedeg=0.5 \
                               --output=$prog.fits \
-                              --tmpdir=tmpdir-$prog --keeptmp
+                              --tmpdir=tmpdir-$prog

reply via email to

[Prev in Thread] Current Thread [Next in Thread]